Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preformatted block: Missing typography controls #28097

Closed
paaljoachim opened this issue Jan 11, 2021 · 2 comments
Closed

Preformatted block: Missing typography controls #28097

paaljoachim opened this issue Jan 11, 2021 · 2 comments
Labels
[Block] Preformatted Affects the Preformatted Block - used for showing preformatted text Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

We are adding typography and color controls to the text blocks that still do not have these features.

This issue is focused on the Preformatted block that still needs typography controls.

Screen Shot 2021-01-11 at 13 39 34

Associated issue:
Consider adding color and text size customizations to all text-based blocks.
#8171
@paaljoachim paaljoachim changed the title Preformatted block: we need to add typography controls Preformatted block: Missing typography controls Jan 11, 2021
@paaljoachim paaljoachim added [Block] Preformatted Affects the Preformatted Block - used for showing preformatted text [Type] Enhancement A suggestion for improvement. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Dev Ready for, and needs developer efforts Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Jan 11, 2021
@donnapep
Copy link
Contributor

@paaljoachim Looks like font size is already supported. Presumably we don't want to add font family. Perhaps this can be closed?

@paaljoachim
Copy link
Contributor Author

Ahhh yes. Thank you Donna @donnapep !
I will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Preformatted Affects the Preformatted Block - used for showing preformatted text Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donnapep @paaljoachim