Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Block: Match the editor to the front end #27803

Closed
scruffian opened this issue Dec 18, 2020 · 8 comments
Closed

HTML Block: Match the editor to the front end #27803

scruffian opened this issue Dec 18, 2020 · 8 comments
Labels
[Block] HTML Affects the the HTML Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@scruffian
Copy link
Contributor

scruffian commented Dec 18, 2020

Is your feature request related to a problem? Please describe.
The HTML block doesn't look the same in the editor and the frontend.

Describe the solution you'd like
We should update the CSS so that the block looks the same in both places. We should also add some customizations to the blocks:

  • Colors
  • Custom spacing
  • Border controls

Describe alternatives you've considered
We could just do this in CSS first

Partly addressed in #9129

@scruffian scruffian added [Block] HTML Affects the the HTML Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 18, 2020
@mtias
Copy link
Member

mtias commented Dec 18, 2020

Can consider it a duplicate of #9129?

@scruffian
Copy link
Contributor Author

I think that PR will help but we also want to add some support for Global Styles

@mtias
Copy link
Member

mtias commented Dec 18, 2020

I mean it's just a case of loading generated styles in the iframe, which is what that issue means to cover

@scruffian
Copy link
Contributor Author

I mean we want to add supports to the block.json for color, spacing, border radius, etc.

@mtias
Copy link
Member

mtias commented Dec 18, 2020

To the HTML block? That seems weird 😁

@scruffian
Copy link
Contributor Author

Well for example if a theme had a dark background it might want to set the background color of the HTML block to match the theme rather than using the default that the editor provides.

@carolinan
Copy link
Contributor

carolinan commented Dec 19, 2020

But the HTML block is for using code, not to display a visual presentation of code or the content in the block.

I think the block works as intended, if the user wants the content of the HTML block to be styled, they add the style.
This gives the block content the flexibility it needs.

@scruffian
Copy link
Contributor Author

Ok, let's close as a duplicate of #9129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] HTML Affects the the HTML Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

No branches or pull requests

3 participants