Add button to cover image

[karmatosed]

This brings the button and options into the cover image block. It takes exactly the settings, including text and background color. The styling of the button is the same but as a default should be white background, black text - to reflect the header styling.

[samikeijonen]

Yes! Very common design pattern. Is this first step towards nested blocks?

[mtias]

@samikeijonen hah, sort of, but not quite. This is more of a setting of the block. The first step for nesting is going to be #2743.

[samikeijonen]

Thanks for the info @mtias, will look the other ticket also.

[jorgefilipecosta]

Submitted PR #3047.

[Soean]

@iseulde The PR for this ticket #3047 was closed because of nested blocks, should this ticket really stay in the 2.0 milestone?

[karmatosed]

@Soean this still would be a setting aside from nesting blocks. It should be a setting on cover image as a lot of people want it.

[melchoyce]

I'd maybe consider "Include button" instead of "Show button" here — what do you think?

[ZebulanStanphill]

If #5452 is merged, this issue could probably be closed, as it would be trivial to insert a Button block into a Cover Image block via nesting.

[mtias]

Yes, that's the plan.

[karmatosed]

I am closing this as we are moving on with nested blocks which will include this.