Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Add custom units to BoxControl #27615

Closed
scruffian opened this issue Dec 9, 2020 · 1 comment · Fixed by #27626
Closed

Global Styles: Add custom units to BoxControl #27615

scruffian opened this issue Dec 9, 2020 · 1 comment · Fixed by #27626
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@scruffian
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The BoxControl component doesn't support custom units.

Describe the solution you'd like
I think the BoxControl component should support custom units so that it can work with Themes that want to use other units.
@scruffian scruffian added [Feature] Full Site Editing Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 9, 2020
This was referenced Dec 9, 2020
Closed
Open
Merged
@scruffian
Copy link
Contributor Author

I have a fix for this here: #27626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BoxControl: Add custom units WordPress/gutenberg
1 participant
@scruffian