Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editing: Add a "Template" tab in the Inspector when editing a template #27470

Closed
jameskoster opened this issue Dec 3, 2020 · 3 comments · Fixed by #28633
Closed

Site Editing: Add a "Template" tab in the Inspector when editing a template #27470

jameskoster opened this issue Dec 3, 2020 · 3 comments · Fixed by #28633
Assignees
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

When editing a template, it would be useful to have a "Template" tab in the inspector. For now this can just display the template details. In the future it can be a home for revisions (like posts), and other template settings / options.

Here's an exciting screenshot:

Screenshot 2020-12-03 at 14 21 37

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 1, 2021

A question comes up....
Do we want to have three tabs?
Post/Page - Block - Template

Clicking the Template tab would bring focus to template parts in the post or page one is in. (As a switcher.)

Post-Block-Template-Tabs

These tabs creates a shift in focus.
In the layout: Click outside any block and Post settings will automatically be selected.
In the sidebar: Click the Post tab and switch to the Post settings.

In the layout: Click a block and notice the automatic shift of focus over to the Block tab options.
In the sidebar: (When no block is selected) Click the Block tab and see the message no Block selected.

In the layout: Click the header/footer etc template and the sidebar tab could switch over to template.
In the sidebar: Click the Template tab and switch focus to site editing and template options.

The Post/Page settings could contain a more obvious shift between post/page <-> template focus.
Yes there is an edit template today, but it is not obvious how to bring focus back to the post content editing.

Clicking a block in the layout automatically switches the focus to the Block tab as that is associated with the block that is selected. Clicking the Template

@jameskoster
Copy link
Contributor Author

One problem with that suggestion – imo – is that it doesn't create enough separation between the document (post/page) and template. If template details are accessible through a tab in the Inspector, I worry that users would perceive the template to be a part of the document somehow, rather than a separate entity in its own right.

I appreciate the desire to reduce friction, but sometimes I think a little friction can be good. It makes the user pause momentarily so that they can understand the scope of the exercise.

Yes there is an edit template today, but it is not obvious how to bring focus back to the post content editing.

We should perhaps discuss this in isolation, but in #27848 a "← Return to post" link is suggested when you move from editing a post to a template:

Screenshot 2021-02-01 at 15 29 52

Keynote employs a similar pattern with their "Done" button that becomes visible when you edit a master slide. It works quite well:

Screenshot 2021-02-01 at 15 30 37

@paaljoachim
Copy link
Contributor

Yeah. Let's keep it to two tabs.

In template mode. The tabs:
Template - Block

The template panel could show some other options or additional options in the Status & visibility. As right now it becomes too similar to the same panel in the post editor screen. Thinking of which options would be natural to have more visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants