Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus undo and unsaved changes notification #26468

Closed
mapk opened this issue Oct 26, 2020 · 2 comments · Fixed by #31757
Closed

Bogus undo and unsaved changes notification #26468

mapk opened this issue Oct 26, 2020 · 2 comments · Fixed by #31757
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Oct 26, 2020

Problem

After updating the Widget Screen, I then reloaded the page (SHIFT + CMD + R) and got a notification that any unsaved changes will not be saved. But I already saved everything when I updated, right? But even though I reload the screen, I still see my change was indeed saved. So I'm not sure which changes the notification is implying.

Example of problem
not-saving

Solution

The "Update" button should save all changes and reloading a newly updated screen should not prompt the notification that there are unsaved changes.

@mapk mapk added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 26, 2020
@draganescu
Copy link
Contributor

I can confirm that the "dirty" state is sometimes triggered even if no change happened such as trying to drag some widget but quitting in the middle of the action.

@draganescu draganescu changed the title Updating Widget Screen does not seem to work correctly Bogus undo and unsaved changes notification Feb 18, 2021
@Mamaduka
Copy link
Member

Mamaduka commented May 12, 2021

Sometimes I've to double click the "Update" button for it to be disabled and indicated that changes were saved. It is probably related to "dirty" state issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants