Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to "block actions" (ellipses dropdown options) #25274

Open
mariohamann opened this issue Sep 13, 2020 · 4 comments
Open

Add icons to "block actions" (ellipses dropdown options) #25274

mariohamann opened this issue Sep 13, 2020 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@mariohamann
Copy link

mariohamann commented Sep 13, 2020

Current state

Coming from the idea of @mapk in #24092 (comment), I realised that there are no icons for actions like "Copy", "Duplicate", "Insert Before" etc.
Screen Recording 2020-09-13 at 12 28 18

I think it would support users to add icons in dropdown, even if those icons are very generic as e. g. in GoogleDrive.
image

Solutions

Based on existing icons I created some new drafts on Figma to discuss:
image

In context:
image

Learnings and questions during the process:

  • It's not easy to distinguish between "copy" and "duplicate".
  • Especially with the "insert before/after" icons I had to see the icons in context to get a feeling for their actual "weight".
  • Currently there is no option for "Paste" and "Cut". :)
  • Should these "Meta"-options always be available in the top toolbar?
  • Why is there an option to "Hide block settings" which is a duplicate of the option in the top toolbar and doesn't really fit the the other options? (I just raised this question in Remove "block" from "Hide Block Settings" and "Show Block Settings" labels #22955 (comment))
@ntsekouras
Copy link
Contributor

Hey @mariohamann - thanks for taking the time to explore this and your proposal. Maybe some folks involved with design could share their thoughts

-cc @mapk @jasmussen

@jasmussen
Copy link
Contributor

Hi @mariohamann thank you for the ticket! And thank you for including lots of visuals, that helps a lot.

As part of the 5.5 effort to advance the block interface, numerous icons were intentionally removed from menus such as the ellipsis menu.

In places, icons have been added back, for example to the reusable block menu item. That happened in #23552 which also moved menu item icons to the right. This was done also to ambiguate between menu items and tools, of which the inline tools in your example should have icons on the left. This also makes the hierarchy clearer when for example you select a tool and have a checkmark on the right:

Screenshot 2020-09-14 at 14 00 30

For that reason I believe it is important that conversations about adding back icons consider their relative importance compared to adjacent items. Ultimately the icons are secondary decorations to the label, and rather than just add them everywhere, we can leverage them to put emphasis to some icons. Google Docs does the same:

Screenshot 2020-09-14 at 14 05 22

Given that, which menu items would you think important enough to need the additional emphasis of an icon? Personally I could see "Group" and potentially "Copy" fit that bill.

@mariohamann
Copy link
Author

mariohamann commented Sep 14, 2020

Thank you for your feedback!

Given that, which menu items would you think important enough to need the additional emphasis of an icon?

Based on my own experience creating content in Gutenberg, I believe Copy, Duplicate, Insert before/after, Add to Reusable Blocks, Group and maybe Remove block are the most important actions. But Remove block is just a nice-to-have and could be dropped first. :)

image

(Thank you for linking to #23552. I have to admit for me it feels a bit strange to put the icons on the right side. I think they should visually support the user and – reading left-to-right – I believe it works much better on the left side as seen in both of your screenshots above. But I will share my concerns in the other issue, too, to keep this issue clean. :))

@mtias
Copy link
Member

mtias commented Jul 14, 2021

I'd suggest to start with group and insert before / after. Those last two are quite important and share functionality, it might be nice to give them more prominence through icons.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Jul 14, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 13, 2021
@ntsekouras ntsekouras removed their assignment Jul 15, 2022
@skorasaurus skorasaurus removed the [Status] In Progress Tracking issues with work in progress label Sep 6, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@mtias @skorasaurus @jasmussen @jordesign @ntsekouras @mariohamann and others