Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Attach the Navigation Component to the WP Button #25260

Closed
Copons opened this issue Sep 11, 2020 · 2 comments
Closed

Site Editor: Attach the Navigation Component to the WP Button #25260

Copons opened this issue Sep 11, 2020 · 2 comments
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items.

Comments

@Copons
Copy link
Contributor

Copons commented Sep 11, 2020

Replace the FullscreenModeClose button with a Navigation toggler.

gutenberg/packages/edit-site/src/components/header/index.js

Lines 84 to 86 in 668a710

<MainDashboardButton.Slot>
<FullscreenModeClose />
</MainDashboardButton.Slot>

The site editor navigation should slide in from the left, and contain a "back to the site" component to navigate back to the dashboard (only in fullscreen mode?).

(Source)
@Copons Copons added [Feature] Full Site Editing [Feature] Navigation Component A navigational waterfall component for hierarchy of items. labels Sep 11, 2020
@Copons Copons mentioned this issue Sep 11, 2020
Closed
@david-szabo97 david-szabo97 mentioned this issue Sep 21, 2020
Merged
8 tasks
@david-szabo97
Copy link
Member

@Copons I think this is safe to close now?

@Copons
Copy link
Contributor Author

Copons commented Sep 25, 2020

@Copons I think this is safe to close now?

Yeah let's close this, since it's technically solved.

If we are not happy with the sidebar behaviour we can iterate on that eventually.

@Copons Copons closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Copons @david-szabo97