Raw Handling: Text with colon incorrectly interpreted as a link

[thomashigginbotham]

Describe the bug
When pasting over existing text, if the new text has a colon in it without first having a space character, Gutenberg will assume you are pasting a link and will open the link insertion dialog box.

To reproduce
Steps to reproduce the behavior:

1. Add some text to a paragraph block.
2. Copy the following text to your clipboard: Bug: This text is not a link
3. Select the text you added to the paragraph block.
4. Paste the text you copied.
5. Notice that you are prompted to insert a link.

Expected behavior
The text should paste without inserting it as a link.

Screenshots

Editor version (please complete the following information):

• WordPress version: 5.5
• Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? default

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Version 84

[kirilzh]

Seems like the problem is in

gutenberg/packages/url/src/is-url.js

Lines 16 to 25 in a4e381b

	export function isURL( url ) {
	// A URL can be considered value if the `URL` constructor is able to parse
	// it. The constructor throws an error for an invalid URL.
	try {
	new URL( url );
	return true;
	} catch {
	return false;
	}
	}

new URL doesn't throw. Maybe we can use valid-url dependency?

[kishanjasani]

@kirilzh there is an issue with isURL.

Is there we are using any packages for the check URL is valid or not? or maybe we can create an additional check here for validating URL.

[mrclay]

I suggest just returning FALSE if the successfully parsed URL pathname begins with whitespace. Or the scheme begins with a capital letter but is not all caps. Otherwise you get in the business of the big list of established URI schemes.

[mrclay]

I can submit a PR on branch 7.7.0 but the master branch fails in attempt to patch xcode (I'm on linux).

[talldan]

There was a similar fix here that it might be possible to take inspiration from - #32663

The difference here is that this problem is pasting something that looks like a link over an existing text selection, whereas that other issue fixed a problem when highlighting text that looks like a link and selecting the link button.

[ndiego]

I have been able to reproduce this.

[R33D3M33R]

Hi,

what a horrible "feature". When you select text and paste something, you want to replace it with the pasted content. You have a button to make a link ...

[annezazu]

Noting that I can replicate this with 6.3 RC 1.