Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector is hidden when inserter is open and stays hidden afterwards #22525

Closed
draganescu opened this issue May 21, 2020 · 3 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Inspector Controls The interface showing block settings and the controls available for each block

Comments

@draganescu
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To reproduce
Steps to reproduce the behavior:

  1. Open a post
  2. Add some content (text, images)
  3. Open the inspector and select a block
  4. Open the block inserter
  5. Observe the inspector is now closed
  6. Close the inserter
  7. Observe the inspector is still closed

Expected behavior
I expect that if something closes something else, closing the something that closed the something else will open the closed something else back,

Screenshots
sidebars

@draganescu draganescu added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Inspector Controls The interface showing block settings and the controls available for each block Needs Design Feedback Needs general design feedback. labels May 21, 2020
@paaljoachim
Copy link
Contributor

We triaged this issue during the Gutenberg Design triage

We noticed the behavior in the smaller browser window.
Settings sidebar is open. Clicking to open the Block Inspector closes the Settings sidebar.
Clicking to close the Block Inspector should reopen the Settings sidebar.
For consistency the sidebar should reopen.

@paaljoachim paaljoachim removed the Needs Design Feedback Needs general design feedback. label May 26, 2020
@jasmussen
Copy link
Contributor

Thank you for the renewed attention on this one!

I'm actually going to close it as "working as intended".

  • When the viewport is small, less than 600px, any open sidebar gets closed and from then on behaves as modal.
  • When the viewport is medium, more than 600px but less than 1440px, the sidebar gets closed when the inserter gets opened, to preserve space, and not reopened.
  • When the viewport is large, more than 1440px, the sidebar isn't touched.

2 is what this ticket is about, but reopening something that was closed is not a simple heuristic — what if the user had a Yoast sidebar open? In that vein, this is working as intended.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 11, 2020

A comment from @talldan here:
#22113 (comment)
"I notice at the moment when opening the inserter menu on narrower screens, the right hand sidebar closes, but then doesn't reopen when the inserter menu is closed. That could be something to improve, and would make this kind of sidebar more usable."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Inspector Controls The interface showing block settings and the controls available for each block
Projects
None yet
Development

No branches or pull requests

3 participants