Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template parts saving behavior is confusing #21512

Closed
youknowriad opened this issue Apr 9, 2020 · 2 comments · Fixed by #21766
Closed

Template parts saving behavior is confusing #21512

youknowriad opened this issue Apr 9, 2020 · 2 comments · Fixed by #21766
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Right now, when you want to override theme's provided template parts and save them while editing a parent template. If it's the first time a theme's template is being customized, the saving will create template parts but only for the given edited template. My expectation is that unless I decide to "fork" the template part, the edited version should override the theme's one in all of the theme templates relying on that template part.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing labels Apr 9, 2020
@vindl
Copy link
Member

vindl commented Apr 9, 2020

cc @Addison-Stavlo since you were looking into saving flow improvements recently.

@Addison-Stavlo
Copy link
Contributor

Yeah, i definitely agree the current behavior with TPs is a bit confusing. I have mostly been improving the interface around the save flow, but there definitely seem to be some underlying issues like this that we will need to handled soon before we are able to implement more desired functionalities.

@epiqueras epiqueras self-assigned this Apr 21, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants