Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Transforms: Refine visuals #21478

Closed
3 tasks
jasmussen opened this issue Apr 8, 2020 · 3 comments
Closed
3 tasks

Block Transforms: Refine visuals #21478

jasmussen opened this issue Apr 8, 2020 · 3 comments
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@jasmussen
Copy link
Contributor

This is what the block transform looks like currently:

Screenshot 2020-04-08 at 11 12 54

This is what it's mocked up to be as part of #18667:

Let's explore how to get them closer.

  • Dark border & zero elevation prop for the popover
  • More consistent colors and typography
  • Better spacing and sizing of icons inside

Here's an additional sketch for transforms:

Screenshot 2020-04-08 at 11 15 31

@jasmussen jasmussen added the Needs Design Feedback Needs general design feedback. label Apr 8, 2020
@karmatosed
Copy link
Member

I love the reduction here to a simple drop-down. Whilst the block library is useful, I don't believe it's something to be used as a pattern anywhere there is a block interaction, so removing it here to offer an easier to read list is an improvement.

I do have a little ponder about the disconnection of the menus, particularly on the 3rd level, that feels awfully far. I think though this could be because I am not experiencing this, so getting into a PR makes sense to feel what the interaction is like.

@mapk
Copy link
Contributor

mapk commented May 4, 2020

Creating a list instead of grid view of these for the Transform tool feels like a great improvement. Most everything coming from the block toolbar is a list already, so this fits well. 👍

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 4, 2020
@jasmussen
Copy link
Contributor Author

This is improved:

Screenshot 2020-10-23 at 10 28 30

It's not perfect, but we can open initial actionable items if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

3 participants