Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked block: visualise instead of showing HTML #2126

Closed
ellatrix opened this issue Aug 1, 2017 · 1 comment · Fixed by #2513
Closed

Locked block: visualise instead of showing HTML #2126

ellatrix opened this issue Aug 1, 2017 · 1 comment · Fixed by #2513
Assignees
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Bug An existing feature does not function as intended
Milestone

Comments

@ellatrix
Copy link
Member

ellatrix commented Aug 1, 2017

I noticed that, if a block is no longer registered, but there are blocks of this type in the content, the HTML is shown. This issue strange as it's now a freeform block internally.

Another issue is that the content now saves as a freeform block. I would expect that, since it is locked, it would keep the block type and preserve everything.

@ellatrix ellatrix added [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Bug An existing feature does not function as intended labels Aug 1, 2017
@mtias mtias added this to the 0.10.0 milestone Aug 18, 2017
@mtias
Copy link
Member

mtias commented Aug 18, 2017

I mentioned leaving an unrecognized block as unrecognized instead of converting to freeform. It may be as simple as not adding the freeform comment at all for freeform blocks (it is the fallback for anything unrecognized, which would include unrecognized blocks as well as just unrecognized markup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants