-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global styles: link color setting #21032
Comments
To go further, the colors should show by default the theme specified ones. You can then click each and replace with a custom color. There is a reset option to clear all. If there aren't any theme set colors it should have defaults. My recommendation would be the blue wee use for links, black, white and a grey. Default suggestions: |
What about the visited links? |
@carolinan do you think they should have a custom colour or default to a variation (darker/lighter) from another? |
I don't think I've seen a different color used for visited in many, many years! |
When reviewing themes it is most notable when the author sets a default color for all link statuses, then adds color options for links and forgets to apply the color to the visited links. It might be just fine to apply the "link color" also to the visited link status. But if the visited link is left defaulting to the theme color, all sort of things can happen like white text over white background. If we look at themes in the theme directory (via wpdirectory.net) , a:active has a larger number than a:visited. I don't think it is common to add a different color to a:active either, it is usually the same color as hover. That has a bigger impact on buttons with a much larger click area. The accessibility benefit if the visited link has a different color than the standard link is likely very small because there would need to also be a text decoration change. |
@carolinan I don't think the visited pseudo state helps anyone. In most CSS stacks/frameworks it is not styled anymore. So to simplify stuff, it would be better to drop the styles for this. |
A common thing to change outside a theme is a link color. When you set that, there is a need to also set hover and active colors. I began exploring what this could look like and a tabbed interface could be an option:
In the context of a larger screen that would look like this:
The text was updated successfully, but these errors were encountered: