Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block uses alignment and justification as terms where other blocks do not #20813

Closed
karmatosed opened this issue Mar 11, 2020 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block

Comments

@karmatosed
Copy link
Member

For most blocks, for example the paragraph blocks the term 'text alignment' is used:

text-alignment

An image block uses 'alignment':

image

The navigation block has a combination of these terms but uses 'justification':

nav-alignmentbeingwidth?

nav-justificationisalignment

I would maybe consider having alignment and text alignment as options in the toolbar because there is past ground for this within other blocks. It might make things make a little more sense. If this isn't agreed, then saying justify text might make more sense than justify items. I still would recommend we don't use the term justify unless we start changing this for other blocks.

@karmatosed karmatosed added the [Block] Navigation Affects the Navigation Block label Mar 11, 2020
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Mar 11, 2020
@mtias
Copy link
Member

mtias commented Mar 11, 2020

These alignments work quite differently than the others. There are a few issues already discussing it.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 11, 2020
@ZebulanStanphill
Copy link
Member

This is a difficult thing to discuss due to the rather confusing terminology WordPress currently uses; a lot of things called "alignments" are not actually alignments. See #19672.

@jasmussen
Copy link
Contributor

Going through the navigation tasks here, I'm actually going to close this one in favor of #19672. There's definitely an alignment conversation to be had, but it's not specific to navigation, as we are adding justification controls also to the Buttons block, potentially to the Social Links block as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

No branches or pull requests

4 participants