Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl - remove URL protocol from Entity (only!) search results #19670

Closed
getdave opened this issue Jan 15, 2020 · 2 comments · Fixed by #20350
Closed

LinkControl - remove URL protocol from Entity (only!) search results #19670

getdave opened this issue Jan 15, 2020 · 2 comments · Fixed by #20350
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@getdave
Copy link
Contributor

getdave commented Jan 15, 2020

Could the URL protocol be dropped?

Originally posted by @mtias in #19513 (comment)

This refers to removing https:// (or similar) on all Entity (eg: Post/Page) search results. This does not apply to direct entries.

So https://www.mywebsite.com/?p=1234 would be displayed as www.mywebsite.com/?p=1234 with the https:// removed.

@getdave getdave self-assigned this Jan 15, 2020
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Jan 15, 2020
@getdave getdave added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 15, 2020
@aduth
Copy link
Member

aduth commented Jan 30, 2020

My initial reaction here is that we should want to be consistent with how these links are presented, either always showing or always omitting the protocol, since a disparity could lead to additional code maintenance overhead and user confusion.

I guess the idea is that:

  • The protocol isn't very nice to see
  • For the current site, it's likely assumed to be "known" already and thus a redundant detail
  • It's important (?) to show the protocol for all other URLs, since a user could want to distinguish

Is the last of these necessarily true though? As a user, is this an important detail for me in choosing amongst a set of suggestions related to my search query? Are there other options for me to get that detail if it was important to me, preferably in a context which is most appropriate (i.e. could I see it in the "View" mode of the link, or at worst I'd still have the option when editing the link again?)

As one point of reference, Google's new redesign doesn't bother to make any distinction of the protocol in the search results. In the following screenshot, the two links are HTTPS and HTTP respectively:

image

Then again, Google's redesign has been widely panned, especially in regards to their presentation of links (though from my readings, moreso on how it obscures the path), so it might not be the best example from which to draw conclusions.

@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Mar 10, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 31, 2020
@draganescu
Copy link
Contributor

I added an alternative PR to @sainthkh 's to remove the display of the protocol. This combined with #21050 which deprecated the use of URL for internal links when rendering, raises how and when should we store the URL in the navigation block?

  • All the time for consistency?
  • Only for external URLs?
  • For internal links, should we store it without protocol but with the protocol omit format, e.g. //localhost/category/post-name so that the browser can use the current protocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
4 participants