Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block set default paragraph color #17953

Closed
thune opened this issue Oct 15, 2019 · 3 comments
Closed

Cover block set default paragraph color #17953

thune opened this issue Oct 15, 2019 · 3 comments
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@thune
Copy link

thune commented Oct 15, 2019

If I have a light background color in the cover block, the default paragraph text becomes invisible. I can change the paragraph block color, but when clicking enter to create a new paragraph inside the cover block the text is yet again white and invisible against a light background. It's annoying that the cover block is just made for dark backgrounds.

@swissspidy swissspidy added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Oct 15, 2019
@ninetyninew
Copy link

ninetyninew commented Oct 27, 2020

We have the same issue - let's say you create a full width cover block for the top of the page, use a background image on it with no opacity then inside you want to add 2 columns, the first with a white cover block inside to create a white box 30% of the cover, when you add a heading or paragraph the default text color is inherited in the CSS and therefore makes the text you are typing white and invisible, it was really hard to determine what was happening, if I apply a dark text color it's visible again but it would be really difficult to spot this has occurred to do that. @thune @swissspidy

@apeatling apeatling added the [Type] Enhancement A suggestion for improvement. label Sep 9, 2021
@glendaviesnz glendaviesnz self-assigned this Sep 14, 2021
@skorasaurus skorasaurus added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 21, 2023
@akasunil
Copy link
Member

With text color option, we can make all inner block placeholder and text visible according to background of cover block.
that being said, we can close this issue now.
Cc: @annezazu

CleanShot 2024-03-14 at 14 28 24@2x

@annezazu
Copy link
Contributor

Thanks for following up. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

9 participants