Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Block: Add Border Colors #17801

Closed
Tracked by #32400
CreativeDive opened this issue Oct 7, 2019 · 5 comments
Closed
Tracked by #32400

Table Block: Add Border Colors #17801

CreativeDive opened this issue Oct 7, 2019 · 5 comments
Labels
[Block] Table Affects the Table Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@CreativeDive
Copy link
Contributor

CreativeDive commented Oct 7, 2019

If the table block has a border, the border color assigned to the background color can not be changed at this time. The table borders are thus without contrast for tables with background color:

Bildschirmfoto 2019-10-07 um 11 25 46

To solve this issue, an additional color selection for the border color would be necessary.

Also a custom color selection for the table background color would be great. At this time only four fix colors are possible.

Bildschirmfoto 2019-10-07 um 11 30 12

@brentswisher brentswisher added [Block] Table Affects the Table Block [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Oct 8, 2019
@karmatosed
Copy link
Member

Over adding yet another section, one option for this could be to contrast change the border depending on the backgrounds set. This could get complicated with multiple ones but they are all more or less on the same level, so I think it could work.

The above said I think as tables are expanded in functionality having a way to colour borders could be something people want.

@ChemicalSailor
Copy link

Related: #16478

@melchoyce melchoyce changed the title Table Block: Missing Style Options Table Block: Add Border Colors Nov 26, 2019
@melchoyce
Copy link
Contributor

Instead of a border color selector, could we instead automatically generate a better border color by darkening the background colors? We already seem to be doing that for the color select borders:

image

@melchoyce melchoyce added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Dec 2, 2019
@karmatosed
Copy link
Member

I think that's a great plan @melchoyce, let's move this into needs dev.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Dec 11, 2019
@javierarce
Copy link
Contributor

javierarce commented Jun 2, 2021

I think we can close this issue since we already support border settings per this PR: #31265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants