-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation block: Immediately insert block when only one block type is allowed #16659
Comments
Looking more into this… |
I made a very terrible "button row" block to test with (will publish later) and I've noticed it would be really nice if the appender (plus button) inserted the only allowed block immediately on click instead of opening the full inserter with a single option. I'll also look into that. Appender in my terrible button row block: It could say "Add BlockName" in the single-allowed-block-type mode. This is the inserter with only one option available. Not very useful: |
@marekhrabe I added a PR, still work in progress I think that should implement this idea: #16708 |
@draganescu Thanks for the PR! I wish you said something sooner. I've assigned the issue to myself, wrote a comment that I'm working on it and even shared some of my progress and yet we ended up working on the same thing in parallel without my knowledge, wasting half of my day :( Please say something next time, I'd be more than happy to pass the issue or collaborate on it. |
@marekhrabe perhaps you can continue with the "Button Row" (or updating core Button) to use this? I'd love to have this: #16480 |
@marekhrabe yes this happens sometimes on GH, I am sorry! I started as an exploration (the branch name is try/*) and shared it as work in progress. I mentioned you exactly because I noticed your comment :) but alas after pushing my code, and figured we could collaborate. Please, feel free to review #16708 and/or propose a better way as I am not sure my take is the best |
@shaunandrews this would also be another great place to discuss the opportunity of implementing this option. As we discussed in this thread you made some very good points on why we shouldn't. As @mtias is the author of this issue and I've also went ahead and implemented an overall update that allows for this feature to happen, independently of the Navigation block, we could arrive here at a conclusion on the steps for moving forward with this small feature. |
Let's add this functionality please, it doesn't make sense to force people to choose a block when there is only one block in the inserter. |
A nice quality of life change would be to tweak the inserter mechanisms for
inner blocks
areas so that if there is only one allowed block type, we insert it instead of opening the inserter.This would allow creating blocks like "buttons row" where the inserter automatically adds a new child block of the specified type, simplifying insertion process.
The text was updated successfully, but these errors were encountered: