Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pullquote with color causes invalid content bug #16429

Closed
DeoThemes opened this issue Jul 5, 2019 · 3 comments · Fixed by #18194
Closed

Pullquote with color causes invalid content bug #16429

DeoThemes opened this issue Jul 5, 2019 · 3 comments · Fixed by #18194
Assignees
@jorgefilipecosta @epiqueras
Labels
[Block] Pullquote Affects the Pullquote Block [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@DeoThemes
Copy link

Describe the bug
When choosing Pullquote with primary color it breaks the block in the editor after page refresh with the following error: This block contains unexpected or invalid content It happens on default 2019 theme.

To reproduce
Steps to reproduce the behavior:

  1. Add basic Pullquote block
  2. Select main color
  3. Update the post
  4. Refresh the page

Screenshots
pullquote

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 75.0.3770.100
@swissspidy swissspidy added [Block] Pullquote Affects the Pullquote Block Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended labels Jul 5, 2019
@epiqueras epiqueras self-assigned this Jul 9, 2019
@epiqueras epiqueras added this to the Gutenberg 6.2 milestone Jul 9, 2019
@epiqueras epiqueras added [Package] Editor /packages/editor and removed Needs Testing Needs further testing to be confirmed. labels Jul 9, 2019
@epiqueras epiqueras mentioned this issue Jul 9, 2019
Closed
5 tasks
@gziolo gziolo removed this from the Gutenberg 6.2 milestone Jul 30, 2019
@pmmueller
Copy link

Why was this removed from the 6.2 milestone?

A simple pullquote like this not working properly is so annoying...

@CreativeDive
Copy link
Contributor

+1 Waiting for the bugfix.

@DesignerThan95
Copy link

DesignerThan95 commented Oct 24, 2019 •
edited
Loading

I have the same problem in this theme but also in my own theme. To get the colors the customizer sets, it is needed to update the color palette and I think, as soon as this happens, the pullquote with default styling gets somehow destroyed.

The twentynineteen Theme does update the colors while loading the editor, but I am not 100% sure, so after a reload it is destroyed. I in my theme do it when the customizer gets saved but that has the same effect.
Maybe someone has a idea how to solve that problem.

@jorgefilipecosta jorgefilipecosta mentioned this issue Oct 30, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

@epiqueras epiqueras

Labels
[Block] Pullquote Affects the Pullquote Block [Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
8 participants
@gziolo @swissspidy @pmmueller @DesignerThan95 @jorgefilipecosta @DeoThemes @epiqueras @CreativeDive