Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'H' bigger #16139

Closed
karmatosed opened this issue Jun 12, 2019 · 4 comments
Closed

Make 'H' bigger #16139

karmatosed opened this issue Jun 12, 2019 · 4 comments
Assignees
Labels
[Block] Heading Affects the Headings Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface

Comments

@karmatosed
Copy link
Member

The 'H' on heading block in block library has padding issues compared to others.

image

@swissspidy swissspidy added [Block] Heading Affects the Headings Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Needs design efforts. labels Jun 13, 2019
@Soean
Copy link
Member

Soean commented Jun 24, 2019

Dashicons (Like the heading "H") are 20x20 px, all others are 24x24 px, not sure why this was added: https://github.com/WordPress/gutenberg/blob/3c0b12be9090975421cdaa68dc03e15c4913721f/packages/components/src/icon/index.js

@karmatosed
Copy link
Member Author

I think this doesn't need design as it can be changed to fix this. Please add back in the label if that is the case.

@karmatosed karmatosed removed the Needs Design Needs design efforts. label Jun 26, 2019
@sarahmonster
Copy link
Member

For reference, this is part of the issue:

Screenshot 2019-07-04 at 13 48 59

Screenshot 2019-07-04 at 13 49 31

Here's what it looks like "sized up" to 24px:
Screenshot 2019-07-08 at 11 20 22

Definitely better, but still feels a wee bit out of place due to the heavy lines. To fit better with the other icons used, it feels as though it should be outlined.

Here are a few potential approaches to solving the problem:

  1. Change the H icon in Dashicons itself to use less padding inside the box. This may cause inconsistency with the Dashicon set, and requires hunting down the icon in Trac. (The icon doesn't appear in the Dashicons Github repo or in the Dashicons website, oddly enough.)
  2. Use a custom icon, designed to the Material grid, for the Heading block. This creates a wee bit more overhead, but does allow us to tweak the icon a bit further so it better aligns with the styling we're using for other block library icons. (For instance, we could adjust the width of the lines or use an outline style.)
  3. Use 24x24 for Dashicons. This is the easiest approach here in many ways, but it leads to unintended side effects for those Dashicons that don't have as much padding inside the box:

Screenshot 2019-07-08 at 11 21 15

In the above screenshot, RSS, Search, and Tag all use Dashicons, all of which have significantly less padding inside the box, in spite of being heavier:

Screenshot 2019-07-08 at 11 25 14

Of these options, I suspect 2 (using a custom icon) is probably our best bet in terms of maintaining consistency across icons here, but I'd appreciate additional feedback if there's a better approach!

@mtias
Copy link
Member

mtias commented Mar 7, 2020

Closing per work on #20284

@mtias mtias closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block [Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

No branches or pull requests

5 participants