-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a classic block inside a columns block causes a block validation failure. #13187
Comments
The fact that the classic block is a block without delimiters makes it impossible to use in nested contexts. Maybe we should remove it from all nested contexts or just find a way to add the delimiters in this case. cc @aduth |
Comment delimiters for a classic block are valid, and I expect would be parsed correctly (as valid block, even?). The challenge there is in implementing these changes to the serializer, which is unaware of a context in which a block lives (i.e. nesting): gutenberg/packages/blocks/src/api/serializer.js Lines 254 to 277 in e969954
The messaging around use-case of Classic block being a proper block or a fallback could impact which solution is best. If it's purely meant as a legacy interoperability, I think it'd be reasonable to omit from the inserter, and perhaps even from any inserter. Has this been considered previously? |
I don't think it has been considered before. I know some people use it as the main block, I'd worry about removing from all inserters. Can we start by removing it from nested inserters (rootClientId is defined)? |
Just seems to me like inconsistent messaging.
|
Preceding relevant console message (copied here to help those searching for existing known issues):
|
Yes, the classic block is very much needed and nesting should work - until we can replicate its functions in other text blocks like list, heading and paragragh blocks:
And of course, there will be users who prefer to have a whole chuck of text in one block, instead of the current gutenberg implementation where each heading and paragraph and list is a separate block.
|
This issue is becoming a bit higher priority with the introduction of the Group block. |
Are there any Gutenberg team members looking into this? I am seeing some chatter on this bug. It's also breaking some other plugins such as Grids: Layout builder for WordPress. Advance Custom Fields' WYSIWYG editor works in columns as a block, I know the Classic Editor Block is not the same as the ACF WYSIWYG block but there might be some code we can look at? |
Just want to add in on this one. If it really isn't a plan to make core/freeform work as a nested block in a core/column-block it should be explained somewhere in the docs. |
Some takes from loose survey amongst my clients.
This issue (which - let me reiterate it again - cannot be fixed / bypassed / circumvented in any way by content admin when it occurs) together with other block validation errors cropping occasionally without particular reason are a main cause that I’m getting numerous requests from clients to consider implementing alternative block building plugins on their site. It hurts because I consider Gutenberg a step forward and a way to break from overengineered visual builders, however I can’t blame them if Gutenberg experience is for them more bothersome than anything else they played with before. My opinion. This should be made a critical issue and together with discussion about block validation #7604 should be prioritised. These are main reasons people are getting frustrated with G. |
Totally agree with @QuietNoise - this bug is a crippling one; as a usually lower level web programmer looking into WP, it steers me away entirely, because of the immense challenge in doing something really quite easy to just write in HTML - putting some formatted text next to a leaflet map. It's proven impossible to achieve - or at least impossible to edit having achieved it once. The Classic Block is the only block providing the necessary formating options, and it works briefly - but as soon as you leave the editor page, it enters the "invalid state", none of the "Convert to HTML" or "Convert to block" buttons do anything, even deleting the block is impossible. I have to drop to code level and manually delete the chunks and start over. |
I've tested the fix with Gutenberg 6.2.0 and works flawlessly for new containers with Classic editor. I have hundreds of those broken blocks across many site and I wonder if there is a way to restore them without manually re-entering from source. |
Hello, I came across an issue with Columns Block when Classic Block is added. Follow the below steps in WordPress Admin to reproduce.
The below console error appears
Block validation: Block validation failed for
core/column
Is there a workaround for this issue as this is currently blocking my progress of building a website?
Thanks :)
The text was updated successfully, but these errors were encountered: