-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes and front-end #1315
Comments
Related: #963 |
Of course there was a ticket already:) We can close this if necessary. |
Yeah, I think there's enough overlap that we can consolidate discussion there, and we can choose to split it into more granular issues if necessary. Thanks! |
I think these are different enough ideas that they can remain separate tickets. The other ticket seems specifically about styling blocks on the front-end, while I see this more related to how everything ties together. |
lol, nevermind |
Sorry for the fast close @melchoyce 😬 I'm still not entirely clear though, since "tying together" seems to be particularly relevant for #963. Can you be more specific? |
For example...
|
Also would there be any legacy CSS that themes traditionally include that might be provided by core now (gallery styling, etc...) and no longer necessarily the job of the theme. |
I think it would be more that themes could unhook/ overwrite styles, over not their job? As with anything in WP. Having easy unhooking of defaults is important and saves !important circles. |
A really basic question I'm confused on. #963 seems to open up the possibility for complex, custom-defined blocks with CSS provided by the theme (or a plugin for that matter). What I'm still confused about (and what #422 I think was trying to get at) is the really simple stuff that
I know some people have always been luke warm on editor styles (often on developer convenience grounds), but having seen the impact they have on users in person and the degree to which it prevents the need to preview, this feels really important and not necessarily covered by any ticket I can find other than the now-closed #422. |
I'm not sure if this is the correct place for these ideas but here we go. I see two ways how themes, Gutenberg, and front-end work together.
For option 1. (like Tammie wrote above) I'd need easy way to unhook/overwrite styles in a theme. I'd even go as far as unhooking all the front-end styles provided my Core/Gutenberg and write them all in my theme. Option 1. is good approach in a sense that "all" themes would be Gutenberg-ready. Option 2. is good approach for things like full width images. That definition depends so much on theme. Is there a sidebar, how @mrwweb I also feel that basic stuff should look the same in the editor and in the front-end. That's why we have |
If our final goal would be to move the editing experience to the front-end, it makes sense to use the main theme stylesheet file all over the place, without duplicating any code in a separate I don't think it's possible to have a WordPress Core styling for blocks that are working consistently in any theme, as long as there is no standardization about the theme layout and content structure. If there would be standardization, then not sure what would the theme's purpose be — giving a set of fonts and colors? (that could be included in a plugin too). A direction might be to approach the new blocks as we currently address core widgets — their functionality is handled by the Wordpress Core (with no styling), and the theme is responsible for styling them according to the supported options. |
@georgeolaru I feel the same about the
That's absolutely true at least for some blocks. For example blocks that are wider than base content. I personally would like to have full control of front-end styling for all blocks. But full control can also mean that I just unhook WP Core styles and add my own. |
I think this is where Customizer comes in. The editor I think should always be the abstracted preview and structured view into the data that comprises a post. When in the Customizer, however, the actual site's styles apply and the blocks can be seen as they would actually appear on the frontend of the site. Note I also envision the “Customzier” mode to expand beyond accessing the current |
I'm with @karmatosed here, and similar to the no. 1 option that @samikeijonen mentions. If Core provides a block, it should come with some basic styles that can be easily unhooked and rewritten in a custom way by a theme. I think this is important because it makes "theming" more approachable to people. It's a head start if you want it. |
What is the reason you insist on font-family: "Noto Serif",serif; ? |
Closing this as we have mechanisms for both applying block styles on the front end, for themes to overwrite them, and for themes to apply block styles back into the editor. |
I'd like to open this general issue for tracking how Gutenberg, themes, and front-end work together. I know there has been discussions on this already and this could be starting point for discussing them more openly.
I'll bring my ideas once I slept for a while (I need at least 12 hours :)
The text was updated successfully, but these errors were encountered: