Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification needed for I18N package #13132

Closed
dsifford opened this issue Dec 28, 2018 · 2 comments
Closed

Clarification needed for I18N package #13132

dsifford opened this issue Dec 28, 2018 · 2 comments
Assignees
@swissspidy
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] i18n /packages/i18n [Type] Developer Documentation Documentation for developers

Comments

@dsifford
Copy link
Contributor

In the README.md file of the i18n package, it states very bluntly the following...

Note that you will not need to specify domain for the strings.

What does this even mean? Plugin authors don't need to specify textdomain in javascript file i18n functions? Can someone clarify this?

image
@swissspidy
Copy link
Member

Ugh yeah that is totally wrong. Will update the docs.

@swissspidy swissspidy added [Type] Developer Documentation Documentation for developers Internationalization (i18n) Issues or PRs related to internationalization efforts labels Dec 29, 2018
@swissspidy swissspidy self-assigned this Dec 29, 2018
@swissspidy swissspidy added the [Package] i18n /packages/i18n label Dec 29, 2018
@swissspidy swissspidy changed the title [docs] [i18n] clarification needed Clarification needed for I18N package Dec 29, 2018
@youknowriad youknowriad added this to the Documentation & Handbook milestone Jan 9, 2019
@simison simison mentioned this issue Feb 4, 2019
Closed
@youknowriad youknowriad removed this from the Documentation & Handbook milestone Mar 18, 2019
@youknowriad
Copy link
Contributor

This is fixed I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swissspidy swissspidy

Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] i18n /packages/i18n [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @swissspidy @dsifford