Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text Block Not allowing edit image size #12833

Closed
flexerd opened this issue Dec 13, 2018 · 4 comments
Closed

Media & Text Block Not allowing edit image size #12833

flexerd opened this issue Dec 13, 2018 · 4 comments
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@flexerd
Copy link

flexerd commented Dec 13, 2018

Describe the bug
After adding the image block width cannot be changed; If attempt is made to drag image side width, it becomes 100% no further editing is available. Text side seems to overlap on drag-bar

To Reproduce
Steps to reproduce the behavior:

  1. Add Media with Text Block
  2. Add Image
  3. Try to change width of image side
  4. See error

Expected behavior
Expecting to be able to change image width (Worked in Gutenberg 4.7

Screenshots

Desktop (please complete the following information):

  • OS: Win10
  • Chrome
  • 71.0.3578.98

Additional context
Wordpress 5.0.1 Gutenberg 4.7 disabled
No Console JavaScript Errors

@swissspidy swissspidy added Needs Testing Needs further testing to be confirmed. [Block] Media & Text Affects the Media & Text Block labels Dec 13, 2018
@designsimply
Copy link
Member

Tested and confirmed with WordPress 5.0.1 with no active plugins using Chrome 70.0.3538.110 on macOS 10.13.6. @jorgefilipecosta, this appears to be a regression of #12600 but is only happening when the plugin is not in use. If you test with WP 5.0.1 + Gutenberg 4.7.0 it works normally.

12833

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release and removed Needs Testing Needs further testing to be confirmed. labels Dec 13, 2018
@jorgefilipecosta
Copy link
Member

This issue will get solved as soon as core ticket https://core.trac.wordpress.org/ticket/45442 is shipped (5.0.2 probably).

@jorgefilipecosta jorgefilipecosta added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label Dec 13, 2018
@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 22, 2019

NB! Bug on Ipad.
Ipad version: 9.3.5
Safari version: 601.1

Image goes into full width on iPad in Safari with text below.
@jorgefilipecosta

I added this CSS code to produce a temp fix for a smaller media image:

/* Media & Text block. Image too large on iPad. */
.wp-block-media-text__media {
max-width: 300px;
width: 100px;
float: left;
padding: 15px 5px 15px 0;
}

@designsimply
Copy link
Member

Image goes into full width on iPad in Safari with text below.

@paaljoachim I tested adding a Media & Text block with WordPress 5.0.3 and no active plugins from an iPad mini iOS 12.1.1 Safari and found that I was able to both insert an image into a Media & Text block at a normal size and also resize it by using the drag handles.

General triage notes: it seems like you have posted into this closed issue because you think there may have been a regression for the same case or that it was never working for older versions of iOS on iPads, however, because the issue was closed several weeks ago it is not the best place to report an issue unless you think it is minor and are just leaving a note for reference. It can be a tricky balance though to know whether to open a new issue or not! In this case, because the issue is old enough and because I have done a quick test with a modern version of iOS and did not find the bug so far in testing, if you think the problem is worth re-checking from older versions of iOS would you mind opening a new issue and please also make sure to include a quick list of steps for testing (you could copy from the issue above), your iOS/Safari versions (as you have noted here), and also your WordPress version and mention whether or not you are testing with the Gutenberg plugin active and it's version number if you are? Because you mentioned a CSS workaround, it may also be worth noting your theme and theme version number in case it is related. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

No branches or pull requests

5 participants