Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opposite direction typing while using Yoast How-To Block #12669

Closed
masterimmu opened this issue Dec 7, 2018 · 8 comments
Closed

Opposite direction typing while using Yoast How-To Block #12669

masterimmu opened this issue Dec 7, 2018 · 8 comments
Labels
Needs Testing Needs further testing to be confirmed. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@masterimmu
Copy link

masterimmu commented Dec 7, 2018

Description
I am trying to write how-to post in gutenberg editor using Yoast How-To block, After starting typing in block, charterers are being typed in opposite direction eg, if i type "start" it is printing "trats"

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'WordPress Dashboard->New Post.'
  2. Click on 'Add Block->Yoast How-To Block'
  3. Scroll down to 'Yoast Block-> Start typing in Enter step title'
  4. See error

Expected behavior
Should be type in proper direction. eg like "start"

Screenshots
two

Desktop :

  • OS: [e.g. Windows 10]
  • Browser [e.g. Mozila Firefox]
  • Version [e.g. 63.0.3]

Additional context

@arhue
Copy link

arhue commented Dec 7, 2018

This happens to me on any block of text except the primary heading. Worked fine on WP 4.9.x on Gutenberg. Issue started when I updated to 5.0.

EDIT: Changing timezone to a US timezone and back to Asia/Kolkata timezone fixed the issue for me.

@swissspidy swissspidy added [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. Needs Testing Needs further testing to be confirmed. labels Dec 7, 2018
@kcalkmc
Copy link

kcalkmc commented Dec 9, 2018

Tested using Windows 7., Chrome, WP 5.0, Worked fine in that environment.
Not able to duplicate.
It would good to have someone test with Firefox and Windows. In the meantime, recommend reporting issue to Yoast Plugin Support (https://github.com/Yoast/wordpress-seo/issues)

@arhue
Copy link

arhue commented Dec 9, 2018

@kcalkmc I think this specifically happens when you use Asia/Kolkata timezone and upgrade from WP 4.9.x. I had this issue. Changing timezones and changing it back to Asia/Kolkata fixed the issue for me. I had this issue for all blocks except the main heading block, not just Yoast. The OP in this thread is from India as well so I presume he's on the same timezone.

I tried with Chrome/Firefox and Linux so this doesn't appear to be a client side issue. I'll try to reproduce this on a test env if I get some time.

@designsimply
Copy link
Member

@arhue thank you for the extra details. Do these testing steps sound right?

  1. Install WP 4.9.x.
  2. Set timezone to Asia/Kolkata on the Settings > General page.
  3. Upgrade to WP 5.0.
  4. Open any block (e.g. a paragraph block).
  5. Start typing and check to see if the characters appear in the correct order.

Note: consider changing step 2 click "Save Changes" without making a change to the timezone.

Changing timezones and changing it back to Asia/Kolkata fixed the issue for me

I wonder if this triggers an update of something else such as a language setting. May I ask, in your case, did you have an RTL language selected at some point before you upgraded to 5.0 or do you recall if you only ever used English on the site where you saw the problem happen?

@designsimply designsimply added [Status] Needs More Info Follow-up required in order to be actionable. and removed Needs Testing Needs further testing to be confirmed. labels Dec 9, 2018
@arhue
Copy link

arhue commented Dec 9, 2018

@designsimply

Do these testing steps sound right?

Yes, that sounds about right.

I wonder if this triggers an update of something else such as a language setting. May I ask, in your case, did you have an RTL language selected at some point before you upgraded to 5.0 or do you recall if you only ever used English on the site where you saw the problem happen?

Nope. Had selected "English(UK)" as the language throughout.

@masterimmu
Copy link
Author

@kcalkmc Issue already reported to Yoast support
@arhue mentioned in reply

Changing timezone to a US timezone and back to Asia/Kolkata timezone fixed the issue for me.

To obtain more information I did following testings

Test-1. I checked my current time zone
Result: it was "UTC +0" which was "Asia/Kolkata" before the update to WP 5.0. How did it change?

Test-2. Then I tried to reproduce the error by changing timezone to RTL language countries i.e "Riyadh" (Saudi).
Result: Error reappeared. But gone immediately after page refresh.

Test-3. Then I tried 15-20 times to regenerate error by changing and without changing timezone.
Result: Error appeared in both cases, sometimes even without changing timezone.

Test-4. Then I exercised Yoast block in a random way, ie adding steps, speedy typing, speedy input step change etc
Result: The error is not in the whole block, If the error is in step one, step two works fine. It means in my case error is input tag specific.

Test-5. So I checked console output in firefox debugging mode. I took the screenshot of the console in both cases with error and without error.
Result: error appeared in console related to javascripts .

My Conclusion:

In my case it is possible that the error is with javascripts being used by text editors integrated in gutenberg/plugin blocks (based on result of Test-5)
for example: tynymce.min.js ,editor.min.js

this issue needs to be addressed by js expert.

for further testing and error reproducing refer Test-2,3 & 4.

@swissspidy @designsimply
thanks for support.

@designsimply
Copy link
Member

Thanks for the additional info!

@designsimply designsimply added Needs Testing Needs further testing to be confirmed. and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Dec 11, 2018
@aduth
Copy link
Member

aduth commented May 31, 2019

@arhue thank you for the extra details. Do these testing steps sound right?

  1. Install WP 4.9.x.
  2. Set timezone to Asia/Kolkata on the Settings > General page.
  3. Upgrade to WP 5.0.
  4. Open any block (e.g. a paragraph block).
  5. Start typing and check to see if the characters appear in the correct order.

I've run through these steps and have not been able to reproduce. The RichText component which powers text interactions has been largely rewritten between WordPress versions 5.1 and 5.2, and it's quite likely to have resolved (or at least impacted) this behavior.

Issues specific to plugins should be reported to their respective issue trackers. Noting that this has been resolved upstream, there does not appear to be an actionable task here.

@aduth aduth closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

6 participants