Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable blocks: Trashed blocks appear in editor and frontend #12339

Closed
noisysocks opened this issue Nov 26, 2018 · 2 comments
Closed

Reusable blocks: Trashed blocks appear in editor and frontend #12339

noisysocks opened this issue Nov 26, 2018 · 2 comments
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Milestone

Comments

@noisysocks
Copy link
Member

noisysocks commented Nov 26, 2018

Reusable blocks that have been trashed should no longer appear in posts and pages that use it.

Steps to reproduce

  1. Create a new post
  2. Insert a block
  3. Convert the block to a reusable block
  4. Go to Manage All Reusable Blocks
  5. Trash the reusable block you created
  6. Go back to the post you created. Note that the reusable block still appears
  7. Preview the post. Note that the reusable block still appears

Expected result

The trashed reusable block should appear as Missing or deleted in the editor, and not render at all in the frontend.

Actual result

The reusable block appears in both the editor and frontend.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Nov 26, 2018
@noisysocks noisysocks added this to the WordPress 5.0 milestone Nov 26, 2018
@noisysocks noisysocks self-assigned this Nov 26, 2018
@GlennMartin1
Copy link

I think it's been this way since the beginning.

To actually remove the reusable block, it's got to be removed from the trash (empty trash).

Perhaps I should have reported this before - I quit reporting since hundreds of other reported bugs are not being addressed, either.

@noisysocks
Copy link
Member Author

Yes this is an oversight from when the feature was implemented in #9588. I don't think the current behaviour is desirable.

Please keep submitting detailed bug reports—they are very useful even if some reports get lost in the chaos 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants