Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using "/" to add block when you have more than 10 blocks matching the search word #11897

Closed
slimmilkduds opened this issue Nov 15, 2018 · 5 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@slimmilkduds
Copy link

We have 100s of reusable blocks, many which follow a similar naming convention. If you have more than 10 blocks that should be listed for a certain search word they don't appear in the list.

To Reproduce
Steps to reproduce the behavior:

  1. Create 15 reusable blocks with the names "keyword 1", "keyword 2", "keyword 3", "keyword 4" etc
  2. search for "keyword" using the / shortcut
  3. only 10 of the 15 blocks are shown

Request
Not really sure, a scrollbar would be nice, or a "load more results". Something to at least suggest that you are not seeing everything that's actually available.

@swissspidy swissspidy added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Nov 15, 2018
@mtias mtias added this to the Future: 5.1 milestone Nov 15, 2018
@mtias mtias added the [Type] Enhancement A suggestion for improvement. label Nov 15, 2018
@draganescu draganescu added the Needs Design Needs design efforts. label Apr 20, 2020
@draganescu
Copy link
Contributor

I added a needs design label because for 100s of items I guess a scrollbar wouldn't help much and another interaction, well, needs design :)

@enriquesanchez enriquesanchez added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Apr 28, 2020
@enriquesanchez
Copy link
Contributor

For the design part, I wonder how much of an issue this still is now that we have a much taller block inserter, which has enough room to display more results.

But I agree, the search results should display all available items via scrolling or a "Show more" button.

@enriquesanchez
Copy link
Contributor

I wonder how much of an issue this still is now that we have a much taller block inserter, which has enough room to display more results

Correcting myself, because I understood this issue was happening in the main block inserter but the issue happens in the 'slash inserter'. I have created 20 reusable blocks all namespaced with "keyword" and I only see 10 results:

Screen Shot 2020-04-28 at 12 04 53

The block inserter, for comparison:

2020-04-28 12-00-53 2020-04-28 12_02_04


I think that allowing scroll would be the most obvious approach here, but I wonder if there are any historical reasons why we don't have it here. Perhaps @mapk or @karmatosed can chime in.

@enriquesanchez
Copy link
Contributor

From #21080 (comment):

For quick inserter we have to be careful with how things expand when searching since it can take over the entire page. I can see listing a row of patterns there and an "browse all" link that just opens the sidebar panel for a better experience.

A "View more" link that takes you to the main inserter is also worth exploring.

@mapk
Copy link
Contributor

mapk commented May 12, 2020

The / inserter is really meant as a power feature for quickly adding blocks to the page. For this reason, any further UI involved with this interaction reduces its swiftness for adding blocks. I suggest we don't add more features to this feature. 😄

Instead, if there are multiple blocks with similar names, maybe the efficiency is in how the users can name their blocks. Sometimes keeping features limited is part of the power they enable.

In addition, now that the Inserter can be opened persistently, I feel this issue is less of a problem. I'm going to close this out for now.

@mapk mapk closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants