Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3.0-RC-1] floating images create selection issues #11698

Closed
GlennMartin1 opened this issue Nov 9, 2018 · 4 comments
Closed

[4.3.0-RC-1] floating images create selection issues #11698

GlennMartin1 opened this issue Nov 9, 2018 · 4 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@GlennMartin1
Copy link

Describe the bug
Floating images have click-through issues to the underlying paragraph.

To Reproduce

  1. Insert text
  2. Insert image
  3. Float image right/left.
  • If the image is larger than one paragraph , then you cannot select the image.
  • If the image is smaller than one paragraph, then you cannot select the paragraph.
@GlennMartin1
Copy link
Author

This is a 4.3 regression.

@youknowriad
Copy link
Contributor

Probably related to #11357

@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 11, 2018
@youknowriad
Copy link
Contributor

@GlennMartin1 I can't reproduce personally. I do trigger multi-selection sometimes If the mouse moves slightly but I can select in all cases, can you record a screenshot or something?

@youknowriad youknowriad added [Status] Needs More Info Follow-up required in order to be actionable. and removed Needs Testing Needs further testing to be confirmed. labels Nov 12, 2018
@jasmussen jasmussen mentioned this issue Nov 12, 2018
Merged
@jasmussen
Copy link
Contributor

This is fixed by #11748, and let the record be known that Riad is my hero.

The issue is not present in Chrome and Safari:

large img

small img

But the issue is present in Firefox:

small img ff

But with #11748 merged, the issue is no longer present:

fix

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release Browser Issues Issues or PRs that are related to browser specific problems and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youknowriad @designsimply @jasmussen @GlennMartin1