Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Size selector shows image sizes that don't have a label #11443

Closed
pento opened this issue Nov 3, 2018 · 0 comments · Fixed by #11481
Closed

Image Size selector shows image sizes that don't have a label #11443

pento opened this issue Nov 3, 2018 · 0 comments · Fixed by #11481
Assignees
@youknowriad
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Media Anything that impacts the experience of managing media
Milestone
WordPress 5.0 RC

Comments

@pento
Copy link
Member

pento commented Nov 3, 2018

Image sizes should only be those returned by the image_size_names_choose filter, per the add_image_size() documentation.

The current behaviour shows all image sizes. For example, Twenty Seventeen registers the twentyseventeen-thumbnail-avatar image size, which shouldn't be available in the image size dropdown.
@pento pento added [Feature] Media Anything that impacts the experience of managing media Backwards Compatibility Issues or PRs that impact backwards compatability labels Nov 3, 2018
@pento pento added this to the WordPress 5.0 milestone Nov 3, 2018
@youknowriad youknowriad self-assigned this Nov 5, 2018
@youknowriad youknowriad mentioned this issue Nov 5, 2018
Merged
@yassine4999 yassine4999 mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Media Anything that impacts the experience of managing media
Projects
None yet
Milestone
WordPress 5.0 RC
Development

Successfully merging a pull request may close this issue.

Only show the image sizes with names WordPress/gutenberg
2 participants
@youknowriad @pento