Skip to content

Commit

Permalink
Rnmobile/media methods refactor (#13554)
Browse files Browse the repository at this point in the history
* Refactor name of media upload methods.

* Change method name for media upload sync.

* Refactor media request method names on bridge to make clear intent.
  • Loading branch information
SergioEstevao authored and youknowriad committed Mar 6, 2019
1 parent 40ca7bb commit e4f8cc0
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import React from 'react';
import { View, Image, TextInput } from 'react-native';
import {
subscribeMediaUpload,
onMediaLibraryPressed,
onUploadMediaPressed,
onCapturePhotoPressed,
onImageQueryReattach,
requestMediaPickFromMediaLibrary,
requestMediaPickFromDeviceLibrary,
requestMediaPickFromDeviceCamera,
mediaUploadSync,
} from 'react-native-gutenberg-bridge';

/**
Expand Down Expand Up @@ -45,7 +45,7 @@ export default class ImageEdit extends React.Component {

if ( attributes.id && ! isURL( attributes.url ) ) {
this.addMediaUploadListener();
onImageQueryReattach();
mediaUploadSync();
}
}

Expand Down Expand Up @@ -108,25 +108,25 @@ export default class ImageEdit extends React.Component {
const { url, caption, height, width } = attributes;

const onMediaLibraryButtonPressed = () => {
onMediaLibraryPressed( ( mediaId, mediaUrl ) => {
requestMediaPickFromMediaLibrary( ( mediaId, mediaUrl ) => {
if ( mediaUrl ) {
setAttributes( { id: mediaId, url: mediaUrl } );
}
} );
};

if ( ! url ) {
const onUploadMediaButtonPressed = () => {
onUploadMediaPressed( ( mediaId, mediaUri ) => {
const onMediaUploadButtonPressed = () => {
requestMediaPickFromDeviceLibrary( ( mediaId, mediaUri ) => {
if ( mediaUri ) {
this.addMediaUploadListener( );
setAttributes( { url: mediaUri, id: mediaId } );
}
} );
};

const onCapturePhotoButtonPressed = () => {
onCapturePhotoPressed( ( mediaId, mediaUri ) => {
const onMediaCaptureButtonPressed = () => {
requestMediaPickFromDeviceCamera( ( mediaId, mediaUri ) => {
if ( mediaUri ) {
this.addMediaUploadListener( );
setAttributes( { url: mediaUri, id: mediaId } );
Expand All @@ -136,9 +136,9 @@ export default class ImageEdit extends React.Component {

return (
<MediaPlaceholder
onUploadMediaPressed={ onUploadMediaButtonPressed }
onUploadMediaPressed={ onMediaUploadButtonPressed }
onMediaLibraryPressed={ onMediaLibraryButtonPressed }
onCapturePhotoPressed={ onCapturePhotoButtonPressed }
onCapturePhotoPressed={ onMediaCaptureButtonPressed }
/>
);
}
Expand Down

0 comments on commit e4f8cc0

Please sign in to comment.