Skip to content

Commit ad937ab

Browse files
justlevinejustlevine
and
justlevine
authored
fix: setcookie() $value must be string in Gutenberg_HTTP_Signaling_Server::handle_read_pending_messages() (#68411)
Use strings instead of integers for `signaling_server_retries`, since cookies are sent as strings. Co-authored-by: justlevine <[email protected]>
1 parent b984ec9 commit ad937ab

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/experimental/sync/class-gutenberg-http-signaling-server.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ private static function handle_read_pending_messages( $subscriber_to_messages_pa
172172
if ( ! $fd ) {
173173
$retries = isset( $_COOKIE['signaling_server_retries'] ) ? intval( $_COOKIE['signaling_server_retries'] ) : 0;
174174
$secure = ( 'https' === parse_url( home_url(), PHP_URL_SCHEME ) );
175-
setcookie( 'signaling_server_retries', $retries + 1, time() + DAY_IN_SECONDS, SITECOOKIEPATH, '', $secure );
175+
setcookie( 'signaling_server_retries', (string) ( $retries + 1 ), time() + DAY_IN_SECONDS, SITECOOKIEPATH, '', $secure );
176176
echo 'id: ' . time() . PHP_EOL;
177177
echo 'event: error' . PHP_EOL;
178178
echo 'data: ' . 'Could not open required file.' . PHP_EOL . PHP_EOL;
@@ -183,7 +183,7 @@ private static function handle_read_pending_messages( $subscriber_to_messages_pa
183183
if ( isset( $_COOKIE['signaling_server_retries'] ) ) {
184184
$secure = ( 'https' === parse_url( home_url(), PHP_URL_SCHEME ) );
185185
// unset the cookie using a past expiration date.
186-
setcookie( 'signaling_server_retries', 0, time() - DAY_IN_SECONDS, SITECOOKIEPATH, '', $secure );
186+
setcookie( 'signaling_server_retries', '0', time() - DAY_IN_SECONDS, SITECOOKIEPATH, '', $secure );
187187
}
188188

189189
echo 'retry: 3000' . PHP_EOL;

0 commit comments

Comments
 (0)