From 7a61eb0136e5aae53e5f5f282ccfd8001ef5a5b4 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Mon, 2 Jul 2018 10:32:54 -0400 Subject: [PATCH] Rich Text: Remove restoreContentAndSplit Call `onSplit` directly --- editor/components/rich-text/index.js | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/editor/components/rich-text/index.js b/editor/components/rich-text/index.js index ad6d9acd57c275..dc1b651c9391ac 100644 --- a/editor/components/rich-text/index.js +++ b/editor/components/rich-text/index.js @@ -541,7 +541,7 @@ export class RichText extends Component { const before = domToFormat( beforeNodes, format, this.editor ); const after = domToFormat( afterNodes, format, this.editor ); - this.restoreContentAndSplit( before, after ); + this.props.onSplit( before, after ); } else { event.preventDefault(); @@ -661,7 +661,7 @@ export class RichText extends Component { after = this.isEmpty( after ) ? null : after; } - this.restoreContentAndSplit( before, after, blocks ); + onSplit( before, after, ...blocks ); } onNodeChange( { parents } ) { @@ -823,19 +823,6 @@ export class RichText extends Component { } ) ); } - /** - * Calling onSplit means we need to abort the change done by TinyMCE. - * we need to call updateContent to restore the initial content before calling onSplit. - * - * @param {Array} before content before the split position - * @param {Array} after content after the split position - * @param {?Array} blocks blocks to insert at the split position - */ - restoreContentAndSplit( before, after, blocks = [] ) { - this.setContent( this.props.value ); - this.props.onSplit( before, after, ...blocks ); - } - render() { const { tagName: Tagname = 'div',