Skip to content

Commit 76488c1

Browse files
Only show "No items found" when isLoading is false
1 parent f73720d commit 76488c1

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

packages/components/src/combobox-control/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,7 @@ function ComboboxControl( props: ComboboxControlProps ) {
399399
__experimentalRenderItem={
400400
__experimentalRenderItem
401401
}
402+
isLoading={ isLoading }
402403
/>
403404
) }
404405
</div>

packages/components/src/form-token-field/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export function FormTokenField( props: FormTokenFieldProps ) {
7777
__experimentalAutoSelectFirstMatch = false,
7878
__nextHasNoMarginBottom = false,
7979
tokenizeOnBlur = false,
80+
isLoading = false,
8081
} = useDeprecated36pxDefaultSizeProp< FormTokenFieldProps >( props );
8182

8283
if ( ! __nextHasNoMarginBottom ) {
@@ -743,6 +744,7 @@ export function FormTokenField( props: FormTokenFieldProps ) {
743744
onHover={ onSuggestionHovered }
744745
onSelect={ onSuggestionSelected }
745746
__experimentalRenderItem={ __experimentalRenderItem }
747+
isLoading={ isLoading }
746748
/>
747749
) }
748750
</div>

packages/components/src/form-token-field/suggestions-list.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export function SuggestionsList<
3131
suggestions = [],
3232
displayTransform,
3333
instanceId,
34+
isLoading,
3435
__experimentalRenderItem,
3536
}: SuggestionsListProps< T > ) {
3637
const listRef = useRefEffect< HTMLUListElement >(
@@ -157,7 +158,7 @@ export function SuggestionsList<
157158
);
158159
/* eslint-enable jsx-a11y/click-events-have-key-events */
159160
} ) }
160-
{ suggestions.length === 0 && (
161+
{ suggestions.length === 0 && ! isLoading && (
161162
<li className="components-form-token-field__suggestion is-empty">
162163
{ __( 'No items found' ) }
163164
</li>

packages/components/src/form-token-field/types.ts

+6
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,11 @@ export interface FormTokenFieldProps
190190
* @default false
191191
*/
192192
tokenizeOnBlur?: boolean;
193+
194+
/**
195+
* Is the component loading data?
196+
*/
197+
isLoading?: boolean;
193198
}
194199

195200
/**
@@ -207,6 +212,7 @@ export interface SuggestionsListProps<
207212
displayTransform: ( value: T ) => string;
208213
instanceId: string | number;
209214
__experimentalRenderItem?: ( args: { item: T } ) => ReactNode;
215+
isLoading?: boolean;
210216
}
211217

212218
export interface TokenProps extends TokenItem {

0 commit comments

Comments
 (0)