From 6d5c06c061907898081ad87b5b3cd07b56965dbd Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Mon, 27 Jul 2020 09:47:58 +0100 Subject: [PATCH] Update the editor landmark regions (#24196) --- .../e2e-tests/specs/experiments/navigation.test.js | 4 ++-- packages/edit-post/src/components/layout/index.js | 12 +++++++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/packages/e2e-tests/specs/experiments/navigation.test.js b/packages/e2e-tests/specs/experiments/navigation.test.js index 3f9be5ac71d41..df69492521cdd 100644 --- a/packages/e2e-tests/specs/experiments/navigation.test.js +++ b/packages/e2e-tests/specs/experiments/navigation.test.js @@ -335,7 +335,7 @@ describe( 'Navigation', () => { // Scope element selector to the Editor's "Content" region as otherwise it picks up on // block previews. const navBlockItemsLength = await page.$$eval( - '[aria-label="Content"][role="region"] li[aria-label="Block: Link"]', + '[aria-label="Editor content"][role="region"] li[aria-label="Block: Link"]', ( els ) => els.length ); @@ -361,7 +361,7 @@ describe( 'Navigation', () => { // Scope element selector to the "Editor content" as otherwise it picks up on // Block Style live previews. const navBlockItemsLength = await page.$$eval( - '[aria-label="Content"][role="region"] li[aria-label="Block: Link"]', + '[aria-label="Editor content"][role="region"] li[aria-label="Block: Link"]', ( els ) => els.length ); diff --git a/packages/edit-post/src/components/layout/index.js b/packages/edit-post/src/components/layout/index.js index 5f606745b3940..11182f3e4a93d 100644 --- a/packages/edit-post/src/components/layout/index.js +++ b/packages/edit-post/src/components/layout/index.js @@ -52,7 +52,17 @@ import WelcomeGuide from '../welcome-guide'; import ActionsPanel from './actions-panel'; const interfaceLabels = { - leftSidebar: __( 'Block Library' ), + leftSidebar: __( 'Block library' ), + /* translators: accessibility text for the editor top bar landmark region. */ + header: __( 'Editor top bar' ), + /* translators: accessibility text for the editor content landmark region. */ + body: __( 'Editor content' ), + /* translators: accessibility text for the editor settings landmark region. */ + sidebar: __( 'Editor settings' ), + /* translators: accessibility text for the editor publish landmark region. */ + actions: __( 'Editor publish' ), + /* translators: accessibility text for the editor footer landmark region. */ + footer: __( 'Editor footer' ), }; function Layout() {