From 581d9eedeb1dfe9ab9cf3793898bff6f319ee9a5 Mon Sep 17 00:00:00 2001 From: arthur Date: Tue, 27 Feb 2024 14:39:12 +0800 Subject: [PATCH] Address feedback --- .../global-styles/font-library-modal/utils/index.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js b/packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js index 8f9020b4e71a92..a54a9f6f35ee7c 100644 --- a/packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js +++ b/packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js @@ -127,8 +127,10 @@ export async function loadFontFaceInBrowser( fontFace, source, addTo = 'all' ) { * * Note that Font faces that were added to the set using the CSS @font-face rule * remain connected to the corresponding CSS, and cannot be deleted. + * + * @see https://developer.mozilla.org/en-US/docs/Web/API/FontFaceSet/delete. */ -export function unloadFontFaceInBrowser( fontFace, addTo = 'all' ) { +export function unloadFontFaceInBrowser( fontFace, removeFrom = 'all' ) { const unloadFontFace = ( fonts ) => { fonts.forEach( ( f ) => { if ( @@ -141,11 +143,11 @@ export function unloadFontFaceInBrowser( fontFace, addTo = 'all' ) { } ); }; - if ( addTo === 'document' || addTo === 'all' ) { + if ( removeFrom === 'document' || removeFrom === 'all' ) { unloadFontFace( document.fonts ); } - if ( addTo === 'iframe' || addTo === 'all' ) { + if ( removeFrom === 'iframe' || removeFrom === 'all' ) { const iframeDocument = document.querySelector( 'iframe[name="editor-canvas"]' ).contentDocument;