Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Nomenclature changes #45

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Nomenclature changes #45

merged 4 commits into from
Jul 26, 2022

Conversation

luisherranz
Copy link
Member

Fixes #37

  • Replace frontend.js files and Frontend componentes with view.js and View
  • Replace "frontend": true attribute prop with "public": true
  • Replace gutenberg- with wp-block-

Copy link
Collaborator

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not crazy about those wp- prefixes but for now it's not a problem if we want to change them in the future. We should just be mindful so that this "internal" name does not get stuck like FSE (Full Site Editing) did 🙂 .

@michalczaplinski michalczaplinski merged commit 8ebdddf into main Jul 26, 2022
@ockham ockham deleted the nomenclature-changes branch July 27, 2022 10:49
@ockham
Copy link
Collaborator

ockham commented Jul 27, 2022

I'm not crazy about those wp- prefixes but for now it's not a problem if we want to change them in the future. We should just be mindful so that this "internal" name does not get stuck like FSE (Full Site Editing) did 🙂 .

Reading #37, it seems to me that the whole purpose of this PR is to avoid sticking with a gutenberg- prefix (in favor of wp-) 🙈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomenclature suggestions
3 participants