Fix linting issues

Author: gziolo

includes/abilities-api.php

@@ -25,7 +25,7 @@
  *                                  alphanumeric characters, dashes and the forward slash.
  * @param array<string,mixed> $args An associative array of arguments for the ability. This should include
  *                                  `label`, `description`, `input_schema`, `output_schema`, `execute_callback`,
- *                                  `permission_callback`, `meta`, and `ability_class`.
+ *                                  `permission_callback`, `annotations`, `meta`, and `ability_class`.
  * @return ?\WP_Ability An instance of registered ability on success, null on failure.
  *
  * @phpstan-param array{
@@ -35,6 +35,7 @@
  *   permission_callback?: callable( mixed $input= ): (bool|\WP_Error),
  *   input_schema?: array<string,mixed>,
  *   output_schema?: array<string,mixed>,
+ *   annotations?: array<string,mixed>,
  *   meta?: array<string,mixed>,
  *   ability_class?: class-string<\WP_Ability>,
  *   ...<string, mixed>

includes/abilities-api/class-wp-abilities-registry.php

@@ -57,6 +57,7 @@ final class WP_Abilities_Registry {
 	 *   permission_callback?: callable( mixed $input= ): (bool|\WP_Error),
 	 *   input_schema?: array<string,mixed>,
 	 *   output_schema?: array<string,mixed>,
+	 *   annotations?: array<string,mixed>,
 	 *   meta?: array<string,mixed>,
 	 *   ability_class?: class-string<\WP_Ability>,
 	 *   ...<string, mixed>

includes/abilities-api/class-wp-ability.php

@@ -26,7 +26,7 @@ class WP_Ability {
 	 * @since n.e.x.t
 	 * @var array<string,(bool|string)>
 	 */
-	const DEFAULT_ANNOTATIONS = array(
+	protected static $default_annotations = array(
 		// An instruction on how to use the ability.
 		'instruction' => '',
 		// If true, the ability does not modify its environment.
@@ -41,7 +41,6 @@ class WP_Ability {
 		 * on its environment.
 		 */
 		'idempotent'  => false,
-
 	);
 
 	/**
@@ -107,7 +106,7 @@ class WP_Ability {
 	 * @since n.e.x.t
 	 * @var array<string,(bool|string)>
 	 */
-	protected $annotations = self::DEFAULT_ANNOTATIONS;
+	protected $annotations = array();
 
 	/**
 	 * The optional ability metadata.
@@ -179,6 +178,7 @@ public function __construct( string $name, array $args ) {
 	 *   permission_callback: callable( mixed $input= ): (bool|\WP_Error),
 	 *   input_schema?: array<string,mixed>,
 	 *   output_schema?: array<string,mixed>,
+	 *   annotations?: array<string,mixed>,
 	 *   meta?: array<string,mixed>,
 	 *   ...<string, mixed>,
 	 * } $args
@@ -222,7 +222,7 @@ protected function prepare_properties( array $args ): array {
 			);
 		}
 
-		if ( isset( $args['annotations']) && ! is_array( $args['annotations'] ) ) {
+		if ( isset( $args['annotations'] ) && ! is_array( $args['annotations'] ) ) {
 			throw new \InvalidArgumentException(
 				esc_html__( 'The ability properties should provide a valid `annotations` array.' )
 			);
@@ -234,6 +234,11 @@ protected function prepare_properties( array $args ): array {
 			);
 		}
 
+		// Set defaults for optional args.
+		if ( ! isset( $args['annotations'] ) ) {
+			$args['annotations'] = static::$default_annotations;
+		}
+
 		return $args;
 	}