Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sniff handling of PHP 7.3 flexible heredoc newdoc #2039

Closed
dingo-d opened this issue Apr 21, 2022 · 1 comment
Closed

Review sniff handling of PHP 7.3 flexible heredoc newdoc #2039

dingo-d opened this issue Apr 21, 2022 · 1 comment

Comments

@dingo-d
Copy link
Member

dingo-d commented Apr 21, 2022

PHP 7.3 relaxed requirements for heredoc and nowdoc syntax.

The WPCS native sniffs which test for T_HEREDOC and T_NOWDOC tokens will need to be reviewed to make sure that they handle the changes correctly. We'll need to add additional tests that will handle the marker and text within the heredoc/nowdoc enclosing collisions.

We'd also need to see where and in which situations we can use utilities provided by PHPCSUtils package.

Refs:

Related to #764

@dingo-d dingo-d added this to the 3.0.0 milestone Apr 21, 2022
@jrfnl
Copy link
Member

jrfnl commented Aug 18, 2023

All sniffs have been reviewed and fixed to support modern PHP in as far as my imagination reached.

If any more situations would be discovered which need to be taken into account, a new issue should be opened with code samples etc.

Closing this now as fixed.

@jrfnl jrfnl closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants