Requests::Version: update version number #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops.. looks like we forgot something for the release. Only just noticed it when I checked the file diff for the WP Core patch.
jrfnl
force-pushed
the
feature/update-version-constant
branch
from
3368b4a
to
175123e
Compare
schlessera
approved these changes
Jun 4, 2021
|
For anyone coming upon this after the fact: This was discussed off GH and the decision was made that - as we don't know whether there are integrations which rely on the version number, we should play it safe -, so I updated the PR and we have since released version 1.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops.. looks like we forgot something for the release. Only just noticed it when I checked the file diff for the WP Core patch.
As the version constant is generally used to verify the version for using certain features of a package, does this warrant a
1.8.1release ?And if so, should I update the version number to
1.8.1in this PR ?