Disable deserialization in FilteredIterator #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
============================================
- Coverage 93.32% 93.06% -0.27%
- Complexity 761 764 +3
============================================
Files 21 21
Lines 1784 1788 +4
============================================
- Hits 1665 1664 -1
- Misses 119 124 +5
Continue to review full report at Codecov.
|
|
Hi @SergeyBiryukov Thanks for the PR. Could a test be added to verify the behaviour of this fix ? And possibly to disclose the issue (privately) in more detail ? |
whyisjake
added a commit
to whyisjake/Requests
that referenced
this pull request
Nov 2, 2020
This is just an extension, with some tests from WordPress core.
Merged
schlessera
approved these changes
Nov 3, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress 5.5.2 included a security fix to disable deserialization in
Requests_Utility_FilteredIterator:https://core.trac.wordpress.org/changeset/49373
This PR aims to merge that change upstream.