-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify => false does not work with fsockopen #311
Conversation
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
============================================
+ Coverage 92.11% 92.23% +0.12%
Complexity 760 760
============================================
Files 21 21
Lines 1762 1764 +2
============================================
+ Hits 1623 1627 +4
+ Misses 139 137 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good catch! Will fix the tests before merging though.
Did this ever get pulled/addressed? I've run up against this issue and really don't want to have to move to another library as this one suits my needs very nicely (aside from this issue that is) |
@soulseekah Thank you for this PR and sorry for the long wait. This looks like a good change. Would you mind rebasing the PR so it becomes mergable ? |
See WordPress#310 fsockopen will fail
As per the documentation setting verify to false suppresses all SSL checks. Fixes WordPress#310
2c01f62
to
1007e5f
Compare
Rebased. Thank you. |
See #310 fsockopen will fail