Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small caps http verb don't work as expected #204

Closed
ccrims0n opened this issue Apr 11, 2016 · 2 comments · Fixed by #207
Closed

Small caps http verb don't work as expected #204

ccrims0n opened this issue Apr 11, 2016 · 2 comments · Fixed by #207
Labels
Component: Core
Milestone
1.7

Comments

@ccrims0n
Copy link
Contributor

Hello,

I was using request specific function post()/get() but then I decided to shift to request() but I mistakenly forgot to uppercase the HTTP verbs and type was going as post/get which was not recognised by cURL Transport.
I think post should work same as POST, it should be case insensitive.
@rmccue
Copy link
Collaborator

rmccue commented Apr 19, 2016

Requests actually only supports the constants (Requests::POST etc), but we should do this just so it's easier to use. I'll patch :)

@rmccue rmccue mentioned this issue Apr 19, 2016
Merged
@rmccue rmccue added this to the 1.7 milestone Apr 19, 2016
@ccrims0n
Copy link
Contributor Author

Yes, we can uppercase the value of $type. Let me know if you need me for a PR or any update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

Uppercase the method to ensure compatibility WordPress/Requests
2 participants
@rmccue @ccrims0n