Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude impossible campaigns #64

Closed
Nollasko opened this issue May 26, 2024 · 5 comments
Closed

Exclude impossible campaigns #64

Nollasko opened this issue May 26, 2024 · 5 comments
Labels
Enhancement New feature or request

Comments

@Nollasko
Copy link

I think it would be more effective if the miner did not farm campaigns that would end before the miner could get them

@Windows200000 Windows200000 added the Enhancement New feature or request label May 26, 2024
@Windows200000
Copy link
Owner

I think #70 should work, but I am a little scared it could refuse to mine campaigns that are only partly possible.

@Windows200000
Copy link
Owner

image
image

Yeah....

@Windows200000
Copy link
Owner

Windows200000 commented May 26, 2024

image

It is there, but it's not as straight forward to get to it.

@Windows200000
Copy link
Owner

Well, it needs a function to loop through it and find the lowest. I don't have the time to set that up right now, especially since there are functions with the same name, that do very similar, tho not exactly the same stuff in different classes.

If anyone else can do it, I'll review and merge.

@Windows200000
Copy link
Owner

Windows200000 commented May 27, 2024

@Nollasko thinking on it a bit more, the issue is still that the miner can sometimes incorrectly guess progress, as described in #63. This could then also lead to a minable campaign not being mined.

I don't think it makes sense to work on this feature until we find a solution to the above-described issue.

@Nollasko Nollasko closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants