Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it possible to change to left click instead of right click? #21

Open
liadlivnat opened this issue Mar 3, 2016 · 9 comments
Open

Comments

@liadlivnat
Copy link

is it possible to change to left click instead of right click?

@Wildhoney
Copy link
Owner

Yes it is, but it's somewhat experimental. Please close this ticket if everything works out 👍

@liadlivnat
Copy link
Author

Wow, thanks for the fast response,

well it worked, but it cause different issue, when i click inside the element, it perform a click on different element and open the menu again, any idea why?

I'm attaching an image to demonstrate.

animation

@Wildhoney
Copy link
Owner

Hmm.

On your popup element, could you trap the onClick event and invoke event.stopPropagation? It seems as though the event is bubbling up to the "DNS" container.

@liadlivnat
Copy link
Author

works like a magic, thanks so much!

@Wildhoney
Copy link
Owner

No problem 👍

@liadlivnat
Copy link
Author

@Wildhoney any chance you know how to handle the case that the modal will be sticked and not scrolled with the page (i guess it's related to the position fixed) i'm attaching an image.
animation

@Wildhoney
Copy link
Owner

Try position: fixed on the context menu's container 👍

@liadlivnat
Copy link
Author

it's already fixed, your code add's the position fixed to it...

@Wildhoney
Copy link
Owner

Ah bugger — yep. position: absolute? We use fixed because that mimics the browser's behaviour for context menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants