You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to partially address issue #148, I would like to re-implement get_anatomical_layouts function.
input - BrainNetwork Graph that has x, y, z coordinates and integer node labels (0 to n-1) for n nodes
output - return three dictionaries containing appropriate pairs of coordinates for sagittal, coronal and axial slices
This is quite different from anatomical_layout - This function extracts the required coordinates of a node based on the given anatomical layout.
The already-existed function get_anatomical_layouts() in scona/make_figures.py does not work at all, so I will create a new one!
I do not think that this function best fits into visualisation_helpers file, that's why I am thinking to include the newly-created function to the graph_measures file. At least the coordinates of the nodes have a relation to graph measures, rather than just to visualisation.
What do you think? Is that ok?
The text was updated successfully, but these errors were encountered:
I can't think of a use of get_anatomical_layouts that won't be related to visualisation. The coordinates are definitely part of calculating the distance between the regions but that will always use the x, y, z coordinates together. The only use for getting these pairs of coordinates (x, y), (x, z), (y, z) etc is to project the 3D brain onto a 2D plane....for visualisation! So my vote would be to put it in visualisation_helpers. What do you think?
Hi there,
to partially address issue #148, I would like to re-implement
get_anatomical_layouts
function.input - BrainNetwork Graph that has x, y, z coordinates and integer node labels (0 to n-1) for n nodes
output - return three dictionaries containing appropriate pairs of coordinates for sagittal, coronal and axial slices
This is quite different from
anatomical_layout
- This function extracts the required coordinates of a node based on the given anatomical layout.The already-existed function
get_anatomical_layouts()
in scona/make_figures.py does not work at all, so I will create a new one!I do not think that this function best fits into visualisation_helpers file, that's why I am thinking to include the newly-created function to the graph_measures file. At least the coordinates of the nodes have a relation to graph measures, rather than just to visualisation.
What do you think? Is that ok?
The text was updated successfully, but these errors were encountered: