Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new get_anatomical_layouts() function #150

Open
wingedRuslan opened this issue Aug 20, 2019 · 1 comment
Open

Make new get_anatomical_layouts() function #150

wingedRuslan opened this issue Aug 20, 2019 · 1 comment

Comments

@wingedRuslan
Copy link
Collaborator

wingedRuslan commented Aug 20, 2019

Hi there,

to partially address issue #148, I would like to re-implement get_anatomical_layouts function.

input - BrainNetwork Graph that has x, y, z coordinates and integer node labels (0 to n-1) for n nodes
output - return three dictionaries containing appropriate pairs of coordinates for sagittal, coronal and axial slices

This is quite different from anatomical_layout - This function extracts the required coordinates of a node based on the given anatomical layout.

The already-existed function get_anatomical_layouts() in scona/make_figures.py does not work at all, so I will create a new one!

I do not think that this function best fits into visualisation_helpers file, that's why I am thinking to include the newly-created function to the graph_measures file. At least the coordinates of the nodes have a relation to graph measures, rather than just to visualisation.

What do you think? Is that ok?

@KirstieJane
Copy link
Member

Hi @wingedRuslan! Thanks for thinking about this.

I can't think of a use of get_anatomical_layouts that won't be related to visualisation. The coordinates are definitely part of calculating the distance between the regions but that will always use the x, y, z coordinates together. The only use for getting these pairs of coordinates (x, y), (x, z), (y, z) etc is to project the 3D brain onto a 2D plane....for visualisation! So my vote would be to put it in visualisation_helpers. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants