Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of functions in make_figures.py #113

Open
wingedRuslan opened this issue May 31, 2019 · 1 comment
Open

Review of functions in make_figures.py #113

wingedRuslan opened this issue May 31, 2019 · 1 comment
Assignees

Comments

@wingedRuslan
Copy link
Collaborator

While looking through the code in make_figures.py (note: not scripts/make_figure.py) I've noted my findings.

  1. view_corr_mat is redundant, because it is already implemented in scripts/visualisation_commands.py
  1. get_anatomical_layouts has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run

  2. plot_anatomical_network has a df object in the body, but the object is not defined inside the function nor passed as a parameter; does not run

Note: the last the 2 functions are implemented in scripts/make_figures.py, the 1st function in scripts/visualisation_commands.py.

Was the purpose of creating this file to refactor the scripts/make_figures.py file? Because scripts/make_figures.py file is messy and 4000 lines long, so it definitely needs to be refactored.

@wingedRuslan wingedRuslan self-assigned this Jun 1, 2019
@Islast
Copy link
Collaborator

Islast commented Jun 5, 2019

This was indeed my first pass at refactoring the code inside scripts/make_figures . Feel free to abandon it and start over if it's not helpful to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants