Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Development guide: Installation instructions #110

Open
sgibson91 opened this issue May 29, 2019 · 5 comments
Open

Update Development guide: Installation instructions #110

sgibson91 opened this issue May 29, 2019 · 5 comments
Assignees

Comments

@sgibson91
Copy link

sgibson91 commented May 29, 2019

Hey! 👋

Just leaving a quick issue to say that I think the installation instructions in the development guide could have a line to say clone/fork the repo first. As it reads right now, it sounds like the pip command is the only thing a user needs to install scona.

Thanks!

Update 1

Users diving straight into the pip command may see this error message:

Could not detect requirement name for 'git+https://github.com/WhitakerLab/scona.git', please specify one with #egg=your_package_name

Perhaps the command needs to be?:

pip install -e git+https://github.com/WhitakerLab/scona.git#egg=scona

Update 2

Confirmed! pip command should be as described above in Update 1 ☝️Package installs without cloning/forking 🎉

@sgibson91
Copy link
Author

This will also need updating in the Getting Started section of the README

@sgibson91
Copy link
Author

sgibson91 commented May 29, 2019

Why I think the #egg addition is needed

The lovely developers of this package probably haven't noticed this bug in the documentation before as you've probably all got local copies of the repo which contains a setup.py file with the dependencies and builds the egg info. Without a local copy (that is to say, a git clone or fork), pip doesn't know where to get this info from and so asks you to provide it in the command line.

(At least, I think this is what's going on. I might be wrong!)

@sgibson91
Copy link
Author

Yes if I do the following, pip doesn't complain:

git clone https://github.com/WhitakerLab/scona.git
cd scona
pip install git+https://github.com/WhitakerLab/scona.git

So I think it's important to clarify whether or not users need to clone the repo first.

@Islast
Copy link
Collaborator

Islast commented May 29, 2019

This is great feedback @sgibson91, this stuff was all just thrown together by me.

@sgibson91
Copy link
Author

You're welcome @Islast 🙂

@Islast Islast self-assigned this Jun 10, 2019
@Islast Islast mentioned this issue Jun 13, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants