Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update uuid to v10 #847

Merged
merged 3 commits into from
Jun 9, 2024
Merged

update uuid to v10 #847

merged 3 commits into from
Jun 9, 2024

Conversation

bobslavtriev
Copy link
Contributor

No description provided.

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@bobslavtriev/Baileys#uuid
# YARN v2
yarn add @whiskeysockets/baileys@bobslavtriev/Baileys#uuid

@PurpShell
Copy link
Collaborator

why? due to pseudo-randomness? or due to dependency chain? what about speed? Is uuid slower? Is the crypto module slower?

@bobslavtriev
Copy link
Contributor Author

why? due to pseudo-randomness? or due to dependency chain? what about speed? Is uuid slower? Is the crypto module slower?

The old version of UUID has been discontinued, instead of updating it, just use crypto, so you don't need to install additional libs

@PurpShell
Copy link
Collaborator

PurpShell commented Jun 9, 2024 •
edited
Loading

why? due to pseudo-randomness? or due to dependency chain? what about speed? Is uuid slower? Is the crypto module slower?

The old version of UUID has been discontinued, instead of updating it, just use crypto, so you don't need to install additional libs

this is node 19+

PurpShell
PurpShell requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just upgrade to v10

package.json Show resolved Hide resolved
src/Utils/auth-utils.ts Outdated Show resolved Hide resolved
src/Utils/auth-utils.ts Outdated Show resolved Hide resolved
src/Utils/auth-utils.ts Outdated Show resolved Hide resolved
@PurpShell PurpShell changed the title uuid v4 changed to crypto.randomUUID update uuid to v10 Jun 9, 2024
@PurpShell PurpShell merged commit b890063 into WhiskeySockets:master Jun 9, 2024
2 checks passed
PurpShell added a commit that referenced this pull request Jun 12, 2024
@PurpShell
fix(master): fix lockfile (after #847)
c964615
@bobslavtriev bobslavtriev deleted the uuid branch June 13, 2024 19:43
@neglywalker neglywalker mentioned this pull request Aug 2, 2024
Open
@neglywalker neglywalker mentioned this pull request Sep 4, 2024
Open
@neglywalker neglywalker mentioned this pull request Sep 24, 2024
Open
@neglywalker neglywalker mentioned this pull request Oct 31, 2024
Open
Git-RenatoAlcantara pushed a commit to Git-RenatoAlcantara/amarulawebsocket that referenced this pull request Nov 2, 2024
@bobslavtriev @PurpShell @bufftop25
update uuid to v10 (WhiskeySockets#847)
afe4de6 
* Update auth-utils.ts

* uuid removed from package.json

* fix(uuid): update to v10

---------

Co-authored-by: Rajeh Taher <[email protected]>
Git-RenatoAlcantara pushed a commit to Git-RenatoAlcantara/amarulawebsocket that referenced this pull request Nov 2, 2024
@PurpShell @bufftop25
fix(master): fix lockfile (after WhiskeySockets#847)
6c4e3db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PurpShell PurpShell PurpShell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobslavtriev @whiskeysockets-bot @PurpShell