Draft: install include folders of plugins to sdk #2074
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I did a quick and dirty fix for it yesterday but the way you did it is better. One nit-pick, not all plugin includes should be included. We make the distinction between regular plugins (which are cmake module libraries) and library plugins (which are regular shared libraries). You can only ever link against the library plugins anyways so only those should be included. These plugins have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2068 .
This assumes the headers are in "include" for all plugins - this is necessary since the INCLUDES argument of add_imhex_plugin may contain paths to third party libs, whose headers should not be copied.
To fix this I think it is necessary to add a second argument like "PRIVATE_INCLUDES", which is included, but not installed.
With this it possible to append the ui plugin for example:
and to link against it:
In a follow-up in the CMake Template for plugins imho there should be fixed, that: